pyTivo Discussion Forum Forum Index pyTivo Discussion Forum
Answers and the development of pyTivo a TiVo transcoding server
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Movies shouldn't have an episodeTitle
Goto page 1, 2  Next
 
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo
 View previous topic :: View next topic  
Author Message
etienne66



Joined: 02 Apr 2008
Posts: 8

PostPosted: Wed Apr 02, 2008 7:41 pm    Post subject: Movies shouldn't have an episodeTitle Reply with quote

I keep updating the TvBus.tmpl and container.tmpl, but I think this is something that should be included in the distribution.

I see several occurances where the title is used for the episodeTitle and seriesTitle is used for the title.

I don't know why the field names have been swapped around. When they are corrected, everything works fine. This might require a change to the metadata files and the MetaGenerator since the fields have been used incorrectly in the past.

If the episodeTitle is left blank then you are left with "" on the Program page, but if it doesn't exist at all it replicates the Tivo behaviour for movies.

So here are the changes for TvBus.tmpl. There is two instances of each
Code:
<episodeTitle>$escape($video.title)</episodeTitle>

to
Code:
#if $video.episodeTitle
<episodeTitle>$escape($video.episodeTitle)</episodeTitle>
#end if

Code:
<title>$escape($video.seriesTitle)</title>

to
Code:
<title>$escape($video.title)</title>


The change for the container.tmpl is so that the episodeTitle will be shown when the program is not in a root folder and show the title when it is. Again this replicates the Tivo behaviour.

Change to the container.tmpl
Code:
<Duration>$video.duration</Duration>
<Description>$escape($video.description)</Description>
to
Code:
<Duration>$video.duration</Duration>
#if $video.episodeTitle
<EpisodeTitle>$escape($video.episodeTitle)</EpisodeTitle>
#end if
<Description>$escape($video.description)</Description>


Thank you for listening.
Etienne


Last edited by etienne66 on Wed Apr 02, 2008 9:06 pm; edited 1 time in total
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 458
Location: Los Angeles, CA

PostPosted: Wed Apr 02, 2008 8:33 pm    Post subject: Reply with quote

That seems like a good change to me.
Back to top
View user's profile Send private message Visit poster's website
etienne66



Joined: 02 Apr 2008
Posts: 8

PostPosted: Wed Apr 02, 2008 9:08 pm    Post subject: Reply with quote

I made a mistake in the container.tmpl, which I updated. It should have been EpisodeTitle and not episodeTitle.

Darn case sensitivity. Wink

Thanks,
Etienne
Back to top
View user's profile Send private message
rjmitche



Joined: 05 Jan 2008
Posts: 47

PostPosted: Sun May 04, 2008 5:54 pm    Post subject: Reply with quote

I think this mod has been incorporated into the latest windows installer build (correct?).

If so, what should the metadata file for a movie look like to take advantage of the changes?

This is what MasterCephus' (excellent) MetaGenerator program currently creates (genre, actors, etc. removed):
Code:
title : Shrek
episodeTitle : Shrek
movieYear : 2001
description : An ogre, in order to regain his swamp, travels along with an annoying donkey...
isEpisode : false
seriesTitle : Shrek
starRating : x6
mpaaRating : P2
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 458
Location: Los Angeles, CA

PostPosted: Sun May 04, 2008 8:02 pm    Post subject: Reply with quote

etienne66 would probably be the best person to ask. But I believe that episodeTitle should be blank or omitted completely. I am not sure about seriesTitle.
Back to top
View user's profile Send private message Visit poster's website
etienne66



Joined: 02 Apr 2008
Posts: 8

PostPosted: Sun May 04, 2008 8:51 pm    Post subject: Reply with quote

krkeegan is correct.

Movies should not have a seriesTitle or episodeTitle if you want to keep to Tivo's standard.

You can add a time field if you want or pyTivo will default to the current time. The time field is reference to when you recorded the file and affects where it shows up on your NPL if you are sorting by date.
Back to top
View user's profile Send private message
philhu



Joined: 04 Jan 2008
Posts: 474

PostPosted: Sun May 04, 2008 8:53 pm    Post subject: Reply with quote

This is a good thing

I mentioned this behavior way back in Tivo Community post days, before we got our own forums.

This works perfectly

Episodes are now treated with dbl-quotes inside folders and the show name-episode title works as expected at the root level, showing showname and episode title.

This emulates exactly as the Tivo displays it's shows
Back to top
View user's profile Send private message
PeteTV



Joined: 26 Jan 2008
Posts: 13

PostPosted: Wed May 07, 2008 1:58 am    Post subject: Reply with quote

I installed the latest wgw snapshot (May 3rd - http://repo.or.cz/w/pyTivo/wgw.git) because I noticed it fixed ticket #1158 which references this thread. Problem is, it doesn't seem to have fixed the problem.

Looking at the top post in this thread, it refers to changing the "episodeTitle" and "title" tags inside TvBus.tmpl. It appears the tags were changed inside the (upper) "vActualShowing" section but not inside the (lower) "showing" section.
Back to top
View user's profile Send private message
PeteTV



Joined: 26 Jan 2008
Posts: 13

PostPosted: Wed May 07, 2008 2:08 am    Post subject: Reply with quote

PeteTV wrote:
Looking at the top post in this thread, it refers to changing the "episodeTitle" and "title" tags inside TvBus.tmpl. It appears the tags were changed inside the (upper) "vActualShowing" section but not inside the (lower) "showing" section.


Hmmm... Well, it appears while making the change in both places does indeed fix the problem for movies, it also removes the seriesTitle for TV Shows.

In other words, now moves have only a "Title" when displayed on the TiVo (as it should be), but TV Shows no longer have an "Episode Title"... even if one is in the Metadata file.
Back to top
View user's profile Send private message
MasterCephus



Joined: 05 Jan 2008
Posts: 195
Location: Hueytown, AL

PostPosted: Wed May 07, 2008 2:17 am    Post subject: Reply with quote

I have updated the MetaGenerator where will not print out "episodeTitle". It will print "seriesTitle" & "title" for TV shows and just "Title" for movies...
_________________
MetaGenerator
pyTivo Manager
Back to top
View user's profile Send private message
PeteTV



Joined: 26 Jan 2008
Posts: 13

PostPosted: Wed May 07, 2008 2:38 am    Post subject: Reply with quote

MasterCephus wrote:
I have updated the MetaGenerator where will not print out "episodeTitle". It will print "seriesTitle" & "title" for TV shows and just "Title" for movies...


I'm not sure that's correct. Mind you, I'm not using the MetaGenerator (I'm on a Linux system), but it looks to me that with the changes outlined above, this works for a movie:

Code:

  title : Transformers


and this works for a TV show:

Code:

  title : Stargate Atlantis
  episodeTitle : Submersion


When this is done, a movie shows only the title at the top and starts with the "(year)" in the description. And a TV show shows the series title at the top and the description begins with "episode title" (year).
Back to top
View user's profile Send private message
MasterCephus



Joined: 05 Jan 2008
Posts: 195
Location: Hueytown, AL

PostPosted: Wed May 07, 2008 2:42 am    Post subject: Reply with quote

Code:

  title : Stargate Atlantis
  episodeTitle : Submersion


I don't think the above should be right though...from what I have seen on the wiki and through my tests, it should be:

Code:

  seriesTitle : Stargate Atlantis
  title : Submersion


I have tested this and it seems to work (I am using wmcbrine's fork, but it's a couple of versions back...)

I thought that episodeTitle didn't do anything.

_________________
MetaGenerator
pyTivo Manager
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 458
Location: Los Angeles, CA

PostPosted: Wed May 07, 2008 2:52 am    Post subject: Reply with quote

Yeah we changed title and episodeTitle, I was under the impression that the use of title was incorrect. Let me look at this real quick.
Back to top
View user's profile Send private message Visit poster's website
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 458
Location: Los Angeles, CA

PostPosted: Wed May 07, 2008 3:20 am    Post subject: Reply with quote

OK, so we use:
seriesTitle
episodeTitle
Title

So Title looks like it is equal to seriesTitle for TV shows. What is title set to for movies(I don't have any on my machine right now)?
Back to top
View user's profile Send private message Visit poster's website
MasterCephus



Joined: 05 Jan 2008
Posts: 195
Location: Hueytown, AL

PostPosted: Wed May 07, 2008 3:27 am    Post subject: Reply with quote

so does my new release need to be changed?

I am doing the above...

_________________
MetaGenerator
pyTivo Manager
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo All times are GMT
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Site is in NO WAY affiliated with TiVo Inc

Powered by phpBB © 2001, 2005 phpBB Group
phpBB SEO

Get pytivo at SourceForge.net. Fast, secure and Free Open Source software downloads
[ Time: 0.1694s ][ Queries: 12 (0.0081s) ][ GZIP on - Debug on ]