pyTivo Discussion Forum Forum Index pyTivo Discussion Forum
Answers and the development of pyTivo a TiVo transcoding server
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Restructuring the Admin plugin

 
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo
 View previous topic :: View next topic  
Author Message
wmcbrine



Joined: 04 Jan 2008
Posts: 1223

PostPosted: Fri Jul 03, 2009 12:26 am    Post subject: Restructuring the Admin plugin Reply with quote

In my repo now: I've broken the "Admin" plugin, which was doing two unrelated things, into two new plugins: "Settings" and "ToGo". Further, the new plugins don't have to be set up in pyTivo.conf, but are added automatically. If you have an "Admin" share, you can remove it; otherwise, it will just cause a warning on startup. Since it's no longer checked, you'll have to move your tivo_mak and togo_path settings to the Server section, if you haven't already.

The ToGo links will now not be displayed unless both tivo_mak and togo_path are already defined; the Instructions page no longer appears. (Instead, you can set these options from the main Web Configuation.) Direct links to each TiVo appear on the info page, and the pull-down selector no longer appears on the NPL page.

There is no longer a way to keep the Web Configuration (Settings) from appearing, which could previously be done by omitting the Admin share from pyTivo.conf. I'll probably add an option to suppress it, with it being available by default, but I could use more feedback on that. (Yes, I know there should be a password option.)

All this is preparatory to much bigger changes in the ToGo plugin.

_________________
My pyTivo fork
Back to top
View user's profile Send private message
rdian06



Joined: 12 Apr 2008
Posts: 1216

PostPosted: Fri Jul 03, 2009 1:17 am    Post subject: Re: Restructuring the Admin plugin Reply with quote

wmcbrine wrote:

There is no longer a way to keep the Web Configuration (Settings) from appearing, which could previously be done by omitting the Admin share from pyTivo.conf. I'll probably add an option to suppress it, with it being available by default, but I could use more feedback on that. (Yes, I know there should be a password option.)


Definitely allow the option to disable it (since there is no way to password protect it at this time.)
Back to top
View user's profile Send private message
wmcbrine



Joined: 04 Jan 2008
Posts: 1223

PostPosted: Fri Jul 03, 2009 5:38 pm    Post subject: Reply with quote

Yeah, I was meaning more, do you agree that it should be on by default? How many of you would actually want it disabled? Etc.

But anyway, for now, I've added the option "nosettings" to disable it. Also, the ToGo menu is more thoroughly disabled when togo_path and tivo_mak aren't both set. It's now as secure as before the restructuring (i.e., not very), plus you can disable the web config from within itself, which wasn't possible before. (And of course you can disable the settings menu while still enabling ToGo, which also wasn't possible before.)

_________________
My pyTivo fork
Back to top
View user's profile Send private message
rdian06



Joined: 12 Apr 2008
Posts: 1216

PostPosted: Fri Jul 03, 2009 11:30 pm    Post subject: Reply with quote

wmcbrine wrote:
Yeah, I was meaning more, do you agree that it should be on by default? How many of you would actually want it disabled? Etc.


I'm all for having it on by default. Likely the common usage of pyTivo is on a private home net where having it exposed isn't a big deal. The Windows installers have had it on by default for a while now.

The Windows firewall exception created for pyTivo by the March 09 installer scopes access to subnet only which helps if you happen to run pyTivo on a publicly IP'd machine. It might be nice if pyTivo enforced only being able to access the web admin, TivoToGo and HMO from the same subnet by default with separate options to either widen or tighten the access scope.
Back to top
View user's profile Send private message
wmcbrine



Joined: 04 Jan 2008
Posts: 1223

PostPosted: Sat Jul 04, 2009 12:13 am    Post subject: Reply with quote

There is IP-based access control in there already, added by Keary Griffin. It's currently undocumented, partly because Keary didn't document it, and partly because his patches were to add functionality that may technically violate TiVo's TOS. Smile Anyway, you can add the keyword "allowedips" with a space-delimited list:

[Server]
allowedips = 127.0.0.1 192.168.1.

I haven't really tested it.

_________________
My pyTivo fork
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Site is in NO WAY affiliated with TiVo Inc

Powered by phpBB © 2001, 2005 phpBB Group
phpBB SEO

Get pytivo at SourceForge.net. Fast, secure and Free Open Source software downloads
[ Time: 0.1085s ][ Queries: 12 (0.0145s) ][ Debug on ]