pyTivo Discussion Forum Forum Index pyTivo Discussion Forum
Answers and the development of pyTivo a TiVo transcoding server
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Updated DVD Video plugin for pytivo
Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
 
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo
 View previous topic :: View next topic  
Author Message
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Wed Jun 15, 2011 3:44 am    Post subject: Reply with quote

Looking at TheBayers code it doesn't do a test that my updated code does do. That's where I made the previous code so I'm confident I'm onto the issue. I've updated my git.

If it doesn't work I'd like to see the log.

The may still be an issue with the names appearing funny I haven't looked at that one yet.
Back to top
View user's profile Send private message
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Wed Jun 15, 2011 5:51 am    Post subject: Reply with quote

lucasnz wrote:
Looking at TheBayers code it doesn't do a test that my updated code does do. That's where I made the previous code so I'm confident I'm onto the issue. I've updated my git.

If it doesn't work I'd like to see the log.

'Sorry, but it is still failing. Hmm. The ORDER in which I access the titles seems to make a difference, or something. I still have not discerned a pattern. At this point, almost none of the titles are working, but one or two are. A lot of titles that worked once now no longer work. For this log, I found one title in The Abyss folder (T09.mpg) that would play, and a number that would not.


lucasnz wrote:
The may still be an issue with the names appearing funny I haven't looked at that one yet.

Oh, I 've been so focused on the transfer issue I forgot to mention: Whatever you did yesterday seemed to make that better. There are still scenarios where the naming fails, and I really don't have the resources to dig into when and how, but at least with the simplest metafiles (no Ignores with isEpisode set true), the naming works.



pyTivo.log.tar.gz
 Description:

Download
 Filename:  pyTivo.log.tar.gz
 Filesize:  6.91 KB
 Downloaded:  6 Time(s)

Back to top
View user's profile Send private message Visit poster's website
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Wed Jun 15, 2011 7:12 am    Post subject: Reply with quote

Thanks for the time you've spent on this! I thought I'd managed to replicate your issue but I was getting a slightly different error than you... Darn, back to the drawing board.
Back to top
View user's profile Send private message
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Wed Jun 15, 2011 10:25 am    Post subject: Reply with quote

Ok, I've just updated my git. I'm pretty confident I've got the issue now. Can you let me know how that goes?
Back to top
View user's profile Send private message
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Wed Jun 15, 2011 1:49 pm    Post subject: Reply with quote

lucasnz wrote:
Ok, I've just updated my git. I'm pretty confident I've got the issue now. Can you let me know how that goes?

Right you are. That is much, much better. Almost everything seems to be working, now. Out of curiosity, what was it that had my system so conflabulated while your test system was obviously working?
Back to top
View user's profile Send private message Visit poster's website
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Wed Jun 15, 2011 2:03 pm    Post subject: Reply with quote

While going through all these permutations, I ran across a problem with the current version. When I checked, though, it turns out TheBayer's original code has the same issue. Digging into it a bit, it's not surprising, but it also presents something of an issue.

When the systems runs the .VOB through ffmpeg, it strips all the audio channels except for the first one. The thing is, what if the first audio track isn't the one the user wants? In most cases, it will be, but for example the first audio track for 50 First Dates is that annoying one where a couple of the actors yak away reminiscing all the things happening in the film, rather than the ordinary audio originally filmed with the video. Who in heck wants to watch that? The "ordinary" audio track is #3.

In general, one needs to be able to select the audio track at will. The best of worlds would be to transcode all the audio tracks and let the user select the one he wants on the TiVo, which does have the ability to select alternate audio tracks. Would this be possible? Alternately, we need a way to specify the audio track ffmpeg should select during transcoding in the details.txt file.
Back to top
View user's profile Send private message Visit poster's website
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Wed Jun 15, 2011 7:45 pm    Post subject: Reply with quote

If you look at the diffs on the git the changes are very minor. The last one was a timing issue since the DVD Video plugin starts a separate thread to read the vob stream and writes this to ffmpeg. I was ending the thread before ffmpeg had received enough info... This seemed to vary from system to system or dvd to dvd. I did manage to find some that errored on mine. Perhaps my CPU is faster than yours so I didn't see the problem until now?

The question about having multiple audio track has been asked before and I believe you can transfer files with multiple tracks to the TiVo but it ignores all but the first track. You could select the audio channel with TheBayers code. I significantly improved this part of the code but I saw something in one of your log traces that indicated to me it might not work on your system (probably a problem with the regular expression used to read the audio settings. Any way put something like the following in your conf file will help select the audio track. This setting is a global setting so will work on any videos you have in your other shares as well. Basically it reads the line about the audio track and tries to find the closest match. So anything ffmpeg outputs about the audio should be able to be used to match and select a track.

[_tivo_SD]
audio_lang = en, 5.1, 6 channels, ac3

[_tivo_HD]
audio_lang = en, 5.1, 6 channels, ac3
Back to top
View user's profile Send private message
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Wed Jun 15, 2011 8:43 pm    Post subject: Reply with quote

lucasnz wrote:
If you look at the diffs on the git the changes are very minor. The last one was a timing issue since the DVD Video plugin starts a separate thread to read the vob stream and writes this to ffmpeg. I was ending the thread before ffmpeg had received enough info... This seemed to vary from system to system or dvd to dvd. I did manage to find some that errored on mine. Perhaps my CPU is faster than yours so I didn't see the problem until now?

That's entirely possible. This isn't the fastest system on the planet, although it is a 64 bit dual core, 3Ghz IIRC. This would also explain why it sometimes seemed a title would work one time and not another. It's also quite posible the compiler options on my copy of ffmpeg cause it to be marginally slower than yours, at least for this operation.

lucasnz wrote:
The question about having multiple audio track has been asked before and I believe you can transfer files with multiple tracks to the TiVo but it ignores all but the first track. You could select the audio channel with TheBayers code. I significantly improved this part of the code but I saw something in one of your log traces that indicated to me it might not work on your system (probably a problem with the regular expression used to read the audio settings. Any way put something like the following in your conf file will help select the audio track.

I'll give it a shot.

lucasnz wrote:
This setting is a global setting so will work on any videos you have in your other shares as well.

That's not so good. It's entirely possible one might want a particular audio track on a specific DVD.
Back to top
View user's profile Send private message Visit poster's website
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Thu Jun 16, 2011 12:50 am    Post subject: Reply with quote

Nope, it didn't work, even though the first stream is not ac3:

Code:
Input #0, mpeg, from 'pipe:':
  Duration: N/A, start: 0.041500, bitrate: 10888 kb/s
    Stream #0.0[0x1e0]: Video: mpeg2video, yuv420p, 720x480 [PAR 32:27 DAR 16:9], 9800 kb/s, 27.57 fps, 59.94 tbr, 90k tbn, 59.94 tbc
    Stream #0.1[0x82]: Audio: ac3, 48000 Hz, stereo, s16, 192 kb/s
    Stream #0.2[0x81]: Audio: ac3, 48000 Hz, 5.1, s16, 448 kb/s
    Stream #0.3[0x80]: Audio: ac3, 48000 Hz, 5.1, s16, 448 kb/s
Output #0, vob, to 'pipe:':
  Metadata:
    encoder         : Lavf52.87.1
    Stream #0.0: Video: mpeg2video, yuv420p, 720x480 [PAR 32:27 DAR 16:9], q=2-31, 9800 kb/s, 90k tbn, 29.97 tbc
    Stream #0.1: Audio: ac3, 48000 Hz, stereo, 192 kb/s


How can I get this to transfer with stream #0.3, instead of #0.1?
Back to top
View user's profile Send private message Visit poster's website
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Thu Jun 16, 2011 1:15 am    Post subject: Reply with quote

Can you please send me the log for this. As I said, I think I noted an issue earlier in one of your logs (but can't remember which one).

Yes, I agree having the option to set it "locally" as well as globally would be good. Reportedly, you used to be able to do this with TheBayers code. I'll look at adding it as a line you can specify in the details.txt...

I your opinion should the setting be per-dvd or per-track?
Back to top
View user's profile Send private message
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Thu Jun 16, 2011 5:41 am    Post subject: Reply with quote

lucasnz wrote:
Can you please send me the log for this. As I said, I think I noted an issue earlier in one of your logs (but can't remember which one).

Here you go. The broken pipe at the end is because I stopped the transfer after a minute or so.

lucasnz wrote:
Yes, I agree having the option to set it "locally" as well as globally would be good. Reportedly, you used to be able to do this with TheBayers code. I'll look at adding it as a line you can specify in the details.txt...

I your opinion should the setting be per-dvd or per-track?

That's a very good question. Per track would give the most flexibility.



pyTivo.log.tar.gz
 Description:

Download
 Filename:  pyTivo.log.tar.gz
 Filesize:  6.3 KB
 Downloaded:  11 Time(s)

Back to top
View user's profile Send private message Visit poster's website
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Thu Jun 16, 2011 10:54 am    Post subject: Reply with quote

Ok, I've updated my git (both my main git and the DVDVideo plugin) to fix the audio track issue. So let me know how this goes for you.

There is some code in there that allows you to specify the "name" of a track (per DVD). You could use this in conjunction with the global setting to ensure the correct track get's selected. I haven't got this to work yet. So it may need some tweaking or I may just have the wrong stuff in my details.txt file. I'll let you know once I've figured this out.

I may look at adding per-track support later.
Back to top
View user's profile Send private message
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Thu Jun 16, 2011 10:59 pm    Post subject: Reply with quote

Well, there's some progress. Now it ignores track #1, which is the overdub track, but track #2 is also ac3, 5.1, so it uses it instead of track #1. Track #2 is Spanish. That's not really what I want, either.

I tried

audio_spec : Stream #0.3
audio_spec : "Stream #0.3"
audio_spec : #0.3
audio_spec : 0.3

None worked.
Back to top
View user's profile Send private message Visit poster's website
lucasnz



Joined: 13 Sep 2010
Posts: 251

PostPosted: Fri Jun 17, 2011 6:35 am    Post subject: Reply with quote

0x80 should work but that's not a good solution for a global setting.... You really want to set that per dvd or per track.
Back to top
View user's profile Send private message
lrhorer



Joined: 04 Mar 2008
Posts: 153

PostPosted: Fri Jun 17, 2011 12:47 pm    Post subject: Reply with quote

lucasnz wrote:
0x80 should work but that's not a good solution for a global setting.... You really want to set that per dvd or per track.

0x80? Decimal 128? How does that apply?

Edit: Nevermind. I see.
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo All times are GMT
Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
Page 2 of 7

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Site is in NO WAY affiliated with TiVo Inc

Powered by phpBB © 2001, 2005 phpBB Group
phpBB SEO

Get pytivo at SourceForge.net. Fast, secure and Free Open Source software downloads
[ Time: 0.3590s ][ Queries: 19 (0.0289s) ][ GZIP on - Debug on ]